fix:fixCI#3154
Conversation
WalkthroughA GitHub Actions workflow update modifies the Ubuntu dependency installation step to explicitly uninstall any existing Homebrew-installed cmake before reinstalling dependencies. The new command precedes the existing brew install line and is made non-fatal with a trailing “|| true”. No other files or public APIs are changed. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant GA as GitHub Actions Runner (Ubuntu)
participant HB as Homebrew
rect rgb(240,245,255)
note over GA,H B: Updated dependency step
GA->>HB: Check cmake version (brew list --versions cmake)
alt cmake present
GA->>HB: Uninstall cmake (ignore-deps, force)
HB-->>GA: Uninstalled (or ignored errors via || true)
else cmake absent
GA-->>GA: Skip uninstall (|| true prevents failure)
end
GA->>HB: Install gcc@10, automake, cmake, make, binutils
HB-->>GA: Packages installed
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/pika.yml (2)
156-157: Simplify and de-risk the uninstall line (avoid&& ... || trueprecedence traps).
A && B || truecan mask unexpected failures inbrew list. You can get the same non-fatal behavior more clearly with a single uninstall guarded by|| true.- brew list --versions cmake && brew uninstall --ignore-dependencies --force cmake || true + brew uninstall --ignore-dependencies --force cmake || true
160-163: Verify Homebrew gcc@10 availability on macOS-13 runners.
gcc@10may be deprecated in Homebrew; if so, the install and hardcoded paths will fail. Consider falling back togccifgcc@10is unavailable.- export CC=/usr/local/opt/gcc@10/bin/gcc-10 - cmake -B build -DCMAKE_C_COMPILER=/usr/local/opt/gcc@10/bin/gcc-10 -DUSE_PIKA_TOOLS=ON -DCMAKE_BUILD_TYPE=${{ env.BUILD_TYPE }} -DCMAKE_CXX_FLAGS_DEBUG=-fsanitize=address -D CMAKE_C_COMPILER_LAUNCHER=ccache -D CMAKE_CXX_COMPILER_LAUNCHER=ccache + GCC_PREFIX="$(brew --prefix gcc@10 2>/dev/null || brew --prefix gcc)" + export CC="${GCC_PREFIX}/bin/$(basename "$(ls -1 ${GCC_PREFIX}/bin/gcc-* | head -n1)")" + cmake -B build -DCMAKE_C_COMPILER="${CC}" -DUSE_PIKA_TOOLS=ON -DCMAKE_BUILD_TYPE=${{ env.BUILD_TYPE }} -DCMAKE_CXX_FLAGS_DEBUG=-fsanitize=address -D CMAKE_C_COMPILER_LAUNCHER=ccache -D CMAKE_CXX_COMPILER_LAUNCHER=ccache
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/workflows/pika.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: build_on_ubuntu
- GitHub Check: build_on_centos
- GitHub Check: build_on_macos
- GitHub Check: Analyze (go)
Co-authored-by: chejinge <[email protected]>
2 participants
Summary by CodeRabbit